Bug 122790

Summary: Windows XP stack and heap sizes should be unspecified, not 0
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Critical CC: bfulgham, commit-queue, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Patch
none
patch none

Alex Christensen
Reported 2013-10-14 16:33:46 PDT
The stack sizes of 0 was causing WinCairo to crash 100% of the time immediately upon opening WinLauncher because there were problems with making new threads with pthreadVC2.dll. The fix requires this and a change to WinCairoRequirements which Anthony already emailed to Brent.
Attachments
Patch (1.60 KB, patch)
2013-10-14 16:36 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
patch (1.57 KB, patch)
2013-10-17 15:10 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-10-14 16:36:22 PDT
Created attachment 214208 [details] Patch
Roger Fong
Comment 2 2013-10-17 15:07:58 PDT
Can you say in the ChangeLog that the fix is for XP in general? (Since it fixes AppleWin XP too) Unofficial r+
Alex Christensen
Comment 3 2013-10-17 15:10:18 PDT
Created attachment 214518 [details] patch
Geoffrey Garen
Comment 4 2013-10-17 15:19:55 PDT
Comment on attachment 214518 [details] patch r=me
WebKit Commit Bot
Comment 5 2013-10-17 15:45:26 PDT
Comment on attachment 214518 [details] patch Clearing flags on attachment: 214518 Committed r157608: <http://trac.webkit.org/changeset/157608>
WebKit Commit Bot
Comment 6 2013-10-17 15:45:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.