Bug 122788
| Summary: | Tables with display:inline rendered as block element | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, bdakin, bfulgham, dino, jonlee, simon.fraser, zalan |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=125640 | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/f14273b8831a74bb0cbe6214a3dd9ee901d748a0
Table was created as inline renderer and another table block renderer wrapper is
created for table's content. So it was displayed as block element and all its style
properties also associated with inline renderer and was not applied to table.
Creating table inline-table renderer wrapper for table's content if parent
is inline except inline-block parent.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Reverted in https://chromium.googlesource.com/chromium/blink/+/84386bc031b49ced92c765a8f554a595bb050dca
Ahmad Saleem
The issue got merged into another and then it was fixed in 2015 in this commit:
https://chromium.googlesource.com/chromium/src.git/+/622e42ea052437c0d7ce4e66ea5f781b3b6bfb96
Ahmad Saleem
(In reply to Ahmad Saleem from comment #2)
> The issue got merged into another and then it was fixed in 2015 in this
> commit:
>
> https://chromium.googlesource.com/chromium/src.git/+/
> 622e42ea052437c0d7ce4e66ea5f781b3b6bfb96
https://github.com/WebKit/WebKit/blob/73fc4fd89f837a0eb9ceebdd631f2e66730072b4/Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp#L169
&
https://github.com/WebKit/WebKit/blob/73fc4fd89f837a0eb9ceebdd631f2e66730072b4/Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp#L122
&
https://github.com/WebKit/WebKit/blob/73fc4fd89f837a0eb9ceebdd631f2e66730072b4/Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp#L149
etc.
Ahmad Saleem
Test Case (from Mozilla bug) - https://bug928074.bmoattachments.org/attachment.cgi?id=8346204
Mozilla Bug - https://bugzilla.mozilla.org/show_bug.cgi?id=928074
Test Case (from Chrome Bug) - Same as above.
Even test case from bug 125640 is same.
[https://bug-125640-attachments.webkit.org/attachment.cgi?id=219090]
I am not able to reproduce any difference between Chrome Canary 115, Safari 16.5. Only Firefox Nightly 115 has slight gap (1px) between both tables but I think this is not the issue.
I think we can close this and also mark 'bug 125640' as Duplicate of this.
@Alan & @Brent & @Simon - Any input?