Bug 122728

Summary: CTTE: RenderSlider always has an HTMLInputElement.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eflews.bot, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
andersca: review+, eflews.bot: commit-queue-
Patch none

Description Andreas Kling 2013-10-13 07:28:13 PDT 
CTTE: RenderSlider always has an HTMLInputElement.
Comment 1 Andreas Kling 2013-10-13 07:28:40 PDT 
Created attachment 214101 [details]
Patch
Comment 2 EFL EWS Bot 2013-10-13 07:32:02 PDT 
Comment on attachment 214101 [details]
Patch

Attachment 214101 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3776691
Comment 3 EFL EWS Bot 2013-10-13 07:33:04 PDT 
Comment on attachment 214101 [details]
Patch

Attachment 214101 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/3403737
Comment 4 Andreas Kling 2013-10-13 07:34:35 PDT 
Created attachment 214102 [details]
Patch
Comment 5 WebKit Commit Bot 2013-10-13 08:02:32 PDT 
Comment on attachment 214102 [details]
Patch

Clearing flags on attachment: 214102

Committed r157370: <http://trac.webkit.org/changeset/157370>
Comment 6 WebKit Commit Bot 2013-10-13 08:02:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Antti Koivisto 2013-10-13 08:07:53 PDT 
Comment on attachment 214102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214102&action=review

> Source/WebCore/rendering/RenderSlider.cpp:65
> +    return toHTMLInputElement(nodeForNonAnonymous());

For completeness we should have elementForNonAnonymous. RenderElement subclasses should not have access to Nodes at all.