Bug 122728

Summary: CTTE: RenderSlider always has an HTMLInputElement.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eflews.bot, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
andersca: review+, eflews.bot: commit-queue-
Patch none

Andreas Kling
Reported 2013-10-13 07:28:13 PDT
CTTE: RenderSlider always has an HTMLInputElement.
Attachments
Patch (3.37 KB, patch)
2013-10-13 07:28 PDT, Andreas Kling 		andersca: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (4.73 KB, patch)
2013-10-13 07:34 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-10-13 07:28:40 PDT
Created attachment 214101 [details] Patch
EFL EWS Bot
Comment 2 2013-10-13 07:32:02 PDT
Comment on attachment 214101 [details] Patch Attachment 214101 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3776691
EFL EWS Bot
Comment 3 2013-10-13 07:33:04 PDT
Comment on attachment 214101 [details] Patch Attachment 214101 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/3403737
Andreas Kling
Comment 4 2013-10-13 07:34:35 PDT
Created attachment 214102 [details] Patch
WebKit Commit Bot
Comment 5 2013-10-13 08:02:32 PDT
Comment on attachment 214102 [details] Patch Clearing flags on attachment: 214102 Committed r157370: <http://trac.webkit.org/changeset/157370>
WebKit Commit Bot
Comment 6 2013-10-13 08:02:36 PDT
All reviewed patches have been landed. Closing bug.
Antti Koivisto
Comment 7 2013-10-13 08:07:53 PDT
Comment on attachment 214102 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214102&action=review > Source/WebCore/rendering/RenderSlider.cpp:65 > + return toHTMLInputElement(nodeForNonAnonymous()); For completeness we should have elementForNonAnonymous. RenderElement subclasses should not have access to Nodes at all.
Note You need to log in before you can comment on or make changes to this bug.