Bug 122717

Summary: Rewrite Document::body and Document::head in modern style, way clearer and shorter
Product: WebKit Reporter: Darin Adler <darin>
Component: DOMAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, cdumez, commit-queue, eflews.bot, esprehn+autocc, gtk-ews, gyuyoung.kim, kangil.han, kling, philn, rniwa, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 122733    
Bug Blocks:    
Attachments:
Description Flags
Patch kling: review+, eflews.bot: commit-queue-

Darin Adler
Reported 2013-10-13 00:00:42 PDT
Rewrite Document::body and Document::head in modern style, way clearer and shorter
Attachments
Patch (2.32 KB, patch)
2013-10-13 00:01 PDT, Darin Adler 		kling: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-10-13 00:01:10 PDT
Created attachment 214087 [details] Patch
EFL EWS Bot
Comment 2 2013-10-13 00:05:36 PDT
Comment on attachment 214087 [details] Patch Attachment 214087 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3867590
EFL EWS Bot
Comment 3 2013-10-13 00:09:02 PDT
Comment on attachment 214087 [details] Patch Attachment 214087 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/3953510
Build Bot
Comment 4 2013-10-13 00:29:10 PDT
Comment on attachment 214087 [details] Patch Attachment 214087 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3951470
Build Bot
Comment 5 2013-10-13 00:39:09 PDT
Comment on attachment 214087 [details] Patch Attachment 214087 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/3953516
Build Bot
Comment 6 2013-10-13 00:45:03 PDT
Comment on attachment 214087 [details] Patch Attachment 214087 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3952496
kov's GTK+ EWS bot
Comment 7 2013-10-13 01:15:55 PDT
Comment on attachment 214087 [details] Patch Attachment 214087 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/3403655
Darin Adler
Comment 8 2013-10-13 12:19:47 PDT
Committed r157381: <http://trac.webkit.org/changeset/157381>
Alexey Proskuryakov
Comment 9 2013-10-13 14:11:56 PDT
This broke a lot of tests, I'm going to roll out. <http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/10752>
WebKit Commit Bot
Comment 10 2013-10-13 14:14:48 PDT
Re-opened since this is blocked by bug 122733
Alexey Proskuryakov
Comment 11 2013-10-13 14:15:35 PDT
Andreas is going to see if he can fix real quick.
Andreas Kling
Comment 12 2013-10-13 15:09:58 PDT
(In reply to comment #11) > Andreas is going to see if he can fix real quick. https://trac.webkit.org/r157383 https://trac.webkit.org/r157384 That was a silly bug, I should have caught it in review.
Darin Adler
Comment 13 2013-10-13 15:46:25 PDT
I don’t know why I didn’t test. I could have sworn I did. I don’t get why childrenOfType takes a pointer, but doesn’t handle null. We should fix that.
Darin Adler
Comment 14 2013-10-13 15:46:35 PDT
By making it take a reference.
Lucas Forschler
Comment 15 2019-02-06 09:02:56 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note You need to log in before you can comment on or make changes to this bug.