| Summary: | Factor line box code from RenderText to a class | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kling, kondapallykalyan, rakuco | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2013-10-12 10:00:48 PDT
Created attachment 214057 [details]
patch
Comment on attachment 214057 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=214057&action=review > Source/WebCore/rendering/RenderTextLineBoxes.cpp:43 > + m_first = m_last = textBox; We should do this on two lines. > Source/WebCore/rendering/RenderTextLineBoxes.cpp:59 > + m_first = 0; nullptr > Source/WebCore/rendering/RenderTextLineBoxes.cpp:114 > + m_first = m_last = 0; nullptr Also, we should do this on two lines. > Source/WebCore/rendering/RenderTextLineBoxes.cpp:117 > +InlineTextBox* RenderTextLineBoxes::findNext(int offset, int& pos) const Crappy name: pos. > Source/WebCore/rendering/RenderTextLineBoxes.cpp:120 > + return 0; nullptr > Source/WebCore/rendering/RenderTextLineBoxes.cpp:129 > + pos = (offset > currentOffset ? current->len() : current->len() - (currentOffset - offset) ); Extra space before last ')' > Source/WebCore/rendering/RenderTextLineBoxes.cpp:143 > + const InlineTextBox* prev = 0; nullptr > Source/WebCore/rendering/RenderTextLineBoxes.h:45 > + void extract(InlineTextBox*); > + void attach(InlineTextBox*); > + void remove(InlineTextBox*); Seems like these should really take references. Maybe in a later patch? |