| Summary: | Dramatically simplify calculateAdjustedNodes | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||
| Component: | UI Events | Assignee: | Ryosuke Niwa <rniwa> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | andersca, benjamin, commit-queue, darin, esprehn+autocc, kangil.han, kling, koivisto, sam | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 131949 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Ryosuke Niwa
2013-10-11 15:29:02 PDT
Created attachment 214028 [details]
Cleanup
Created attachment 214029 [details]
Cleanup
Created attachment 214032 [details]
Minor tweaks
Comment on attachment 214032 [details]
Minor tweaks
Note that <details> element implementation still uses InsertionPoints. On the other hand we can assume that any functionality without tests is not working anyway.
(In reply to comment #4) > (From update of attachment 214032 [details]) > Note that <details> element implementation still uses InsertionPoints. On the other hand we can assume that any functionality without tests is not working anyway. Maybe I didn't phrase it properly but having a single insertion point is okay as long as the content that got inserted into doesn't have a shadow tree. Since we don't currently expose webkitCreateShadowRoot, this isn't an issue. Committed r157328: <http://trac.webkit.org/changeset/157328> |