Bug 122680

Summary: Dramatically simplify calculateAdjustedNodes
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: UI EventsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, commit-queue, darin, esprehn+autocc, kangil.han, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 131949    
Attachments:
Description Flags
Cleanup
none
Cleanup
none
Minor tweaks koivisto: review+

Ryosuke Niwa
Reported 2013-10-11 15:29:02 PDT
Dramatically simplify calculateAdjustedNodes
Attachments
Cleanup (8.19 KB, patch)
2013-10-11 15:33 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Cleanup (8.23 KB, patch)
2013-10-11 15:34 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Minor tweaks (8.29 KB, patch)
2013-10-11 15:59 PDT, Ryosuke Niwa 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-10-11 15:33:50 PDT
Created attachment 214028 [details] Cleanup
Ryosuke Niwa
Comment 2 2013-10-11 15:34:24 PDT
Created attachment 214029 [details] Cleanup
Ryosuke Niwa
Comment 3 2013-10-11 15:59:27 PDT
Created attachment 214032 [details] Minor tweaks
Antti Koivisto
Comment 4 2013-10-11 17:53:36 PDT
Comment on attachment 214032 [details] Minor tweaks Note that <details> element implementation still uses InsertionPoints. On the other hand we can assume that any functionality without tests is not working anyway.
Ryosuke Niwa
Comment 5 2013-10-11 19:02:35 PDT
(In reply to comment #4) > (From update of attachment 214032 [details]) > Note that <details> element implementation still uses InsertionPoints. On the other hand we can assume that any functionality without tests is not working anyway. Maybe I didn't phrase it properly but having a single insertion point is okay as long as the content that got inserted into doesn't have a shadow tree. Since we don't currently expose webkitCreateShadowRoot, this isn't an issue.
Ryosuke Niwa
Comment 6 2013-10-11 19:07:17 PDT
Committed r157328: <http://trac.webkit.org/changeset/157328>
Note You need to log in before you can comment on or make changes to this bug.