Bug 122675

Summary: Lay the groundwork for a multi-process aware Indexed DB implementation in WebKit2
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, philn, rakuco, xan.lopez, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 - Lay the most basic groundwork, breaking in-process LevelDB users
none
Patch v2 - More ENABLE() guards and project file fixes ap: review+

Brady Eidson
Reported 2013-10-11 12:58:13 PDT
Lay the groundwork for a multi-process aware Indexed DB implementation in WebKit2 The "groundwork" is basically a WebIDBFactoryBackend that stubs out the entry points into the indexed database API, and gives the most basic foundation to build a database process on. This will break current WK2 clients using the in-process LevelDB implementation.
Attachments
Patch v1 - Lay the most basic groundwork, breaking in-process LevelDB users (13.35 KB, patch)
2013-10-11 13:12 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v2 - More ENABLE() guards and project file fixes (14.17 KB, patch)
2013-10-11 13:57 PDT, Brady Eidson 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2013-10-11 13:12:22 PDT
Created attachment 214016 [details] Patch v1 - Lay the most basic groundwork, breaking in-process LevelDB users
WebKit Commit Bot
Comment 2 2013-10-11 13:14:06 PDT
Attachment 214016 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/GNUmakefile.list.am', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/IndexedDB/WebIDBFactoryBackend.cpp', u'Source/WebKit2/WebProcess/IndexedDB/WebIDBFactoryBackend.h', u'Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp']" exit_code: 1 Source/WebKit2/CMakeLists.txt:419: No trailing spaces [whitespace/trailing] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 3 2013-10-11 13:19:13 PDT
(In reply to comment #2) > Attachment 214016 [details] did not pass style-queue: > ... > Source/WebKit2/CMakeLists.txt:419: No trailing spaces [whitespace/trailing] [5] > Total errors found: 1 in 7 files Fixed locally.
Brady Eidson
Comment 4 2013-10-11 13:57:04 PDT
Created attachment 214022 [details] Patch v2 - More ENABLE() guards and project file fixes
Brady Eidson
Comment 5 2013-10-11 15:11:47 PDT
http://trac.webkit.org/changeset/157320 If any WK2 port relying on their in-process IDB working needs a temporary #ifdef, we can do that in WebPlatformStrategies. But as stressed on webkit-dev... it will be *temporary*
Note You need to log in before you can comment on or make changes to this bug.