Bug 122672

Summary:

Virtualize PlatformCALayer

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

Platform

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, buildbot, commit-queue, dino, eric.carlson, glenn, jer.noble, kondapallykalyan, rniwa, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
take one	none
take two	none
take three; fix filtersCanBeComposited	buildbot: commit-queue-
which broke the build	andersca: review+

Tim Horton

Reported 2013-10-11 12:31:15 PDT

We're about to introduce a PlatformCALayer subclass for remote layer tree hosting which needs to co-exist (for now) with normal Mac PlatformCALayer. In order to do this, let's make PlatformCALayer virtual, and add PlatformCALayerWin and PlatformCALayerMac subclasses.

Attachments
take one (90.81 KB, patch) 2013-10-13 22:33 PDT, Tim Horton	no flags	Details Formatted Diff Diff
take two (91.06 KB, patch) 2013-10-13 22:49 PDT, Tim Horton	no flags	Details Formatted Diff Diff
take three; fix filtersCanBeComposited (92.29 KB, patch) 2013-10-14 11:40 PDT, Tim Horton	buildbot: commit-queue-	Details Formatted Diff Diff
which broke the build (93.33 KB, patch) 2013-10-14 12:15 PDT, Tim Horton	andersca: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2013-10-13 22:33:54 PDT

Created attachment 214127 [details] take one

WebKit Commit Bot

Comment 2 2013-10-13 22:35:33 PDT

Attachment 214127 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h', u'Source/WebCore/platform/graphics/ca/PlatformCAAnimation.h', u'Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp', u'Source/WebCore/platform/graphics/ca/PlatformCALayer.h', u'Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h', u'Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm', u'Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp', u'Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp', u'Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h', u'Source/WebCore/platform/graphics/win/GraphicsContext3DWin.cpp', u'Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/FullscreenVideoController.cpp']" exit_code: 1 Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h:38: The parameter name "platformLayer" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h:58: The parameter name "animation" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h:143: The parameter name "layerType" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h:143: The parameter name "layer" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/ca/PlatformCALayer.h:115: The parameter name "animation" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/ca/PlatformCALayer.h:191: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/platform/graphics/ca/PlatformCALayer.h:192: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/platform/graphics/ca/PlatformCALayer.h:193: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h:65: The parameter name "animation" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h:144: The parameter name "layerType" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h:144: The parameter name "layer" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp:59: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 12 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 3 2013-10-13 22:49:28 PDT

Created attachment 214128 [details] take two

Tim Horton

Comment 4 2013-10-14 11:40:48 PDT

Created attachment 214172 [details] take three; fix filtersCanBeComposited

Build Bot

Comment 5 2013-10-14 12:08:53 PDT

Comment on attachment 214172 [details] take three; fix filtersCanBeComposited Attachment 214172 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3950895

Tim Horton

Comment 6 2013-10-14 12:15:15 PDT

Created attachment 214178 [details] which broke the build

Anders Carlsson

Comment 7 2013-10-14 13:16:24 PDT

Comment on attachment 214178 [details] which broke the build View in context: https://bugs.webkit.org/attachment.cgi?id=214178&action=review > Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h:153 > +} // namespace WebCore

Tim Horton

Comment 8 2013-10-14 13:48:39 PDT

http://trac.webkit.org/changeset/157419

Note You need to log in before you can comment on or make changes to this bug.