Bug 122655

Summary: Remove preference support for picking the old Web Inspector.
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Timothy Hatcher
Reported 2013-10-11 10:08:34 PDT
Remove preference support for picking the old Web Inspector.
Attachments
Patch (15.80 KB, patch)
2013-10-11 10:10 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (15.67 KB, patch)
2013-10-11 15:09 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2013-10-11 10:10:13 PDT
Created attachment 213995 [details] Patch
Radar WebKit Bug Importer
Comment 2 2013-10-11 10:14:08 PDT
<rdar://problem/15208571>
Timothy Hatcher
Comment 3 2013-10-11 10:14:53 PDT
Comment on attachment 213995 [details] Patch This will break the nightlies since WKPreferencesSetInspectorUsesWebKitUserInterface is being removed. Will need a stub.
Timothy Hatcher
Comment 4 2013-10-11 15:09:27 PDT
Created attachment 214025 [details] Patch
WebKit Commit Bot
Comment 5 2013-10-11 16:07:32 PDT
Comment on attachment 214025 [details] Patch Clearing flags on attachment: 214025 Committed r157323: <http://trac.webkit.org/changeset/157323>
WebKit Commit Bot
Comment 6 2013-10-11 16:07:35 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 7 2013-10-14 11:56:01 PDT
Looks like this needs to be done for Windows as well: if (!htmlURLRef) htmlURLRef = adoptCF(CFBundleCopyResourceURL(webKitBundle(), CFSTR("inspector"), CFSTR("html"), CFSTR("inspector"))); I'll file a follow-up.
Note You need to log in before you can comment on or make changes to this bug.