Bug 122655

Summary: Remove preference support for picking the old Web Inspector.
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Timothy Hatcher 2013-10-11 10:08:34 PDT 
Remove preference support for picking the old Web Inspector.
Comment 1 Timothy Hatcher 2013-10-11 10:10:13 PDT 
Created attachment 213995 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2013-10-11 10:14:08 PDT 
<rdar://problem/15208571>
Comment 3 Timothy Hatcher 2013-10-11 10:14:53 PDT 
Comment on attachment 213995 [details]
Patch

This will break the nightlies since WKPreferencesSetInspectorUsesWebKitUserInterface is being removed. Will need a stub.
Comment 4 Timothy Hatcher 2013-10-11 15:09:27 PDT 
Created attachment 214025 [details]
Patch
Comment 5 WebKit Commit Bot 2013-10-11 16:07:32 PDT 
Comment on attachment 214025 [details]
Patch

Clearing flags on attachment: 214025

Committed r157323: <http://trac.webkit.org/changeset/157323>
Comment 6 WebKit Commit Bot 2013-10-11 16:07:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Joseph Pecoraro 2013-10-14 11:56:01 PDT 
Looks like this needs to be done for Windows as well:

    if (!htmlURLRef)
        htmlURLRef = adoptCF(CFBundleCopyResourceURL(webKitBundle(), CFSTR("inspector"), CFSTR("html"), CFSTR("inspector")));

I'll file a follow-up.