Bug 122650

Summary: Remove gesture event support from WebCore
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cmarcelo, commit-queue, esprehn+autocc, gyuyoung.kim, kangil.han, rakuco, rniwa
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+, buildbot: commit-queue-

Description Anders Carlsson 2013-10-11 09:44:18 PDT 
Remove gesture event support from WebCore
Comment 1 Anders Carlsson 2013-10-11 09:50:01 PDT 
Created attachment 213994 [details]
Patch
Comment 2 Build Bot 2013-10-11 10:26:15 PDT 
Comment on attachment 213994 [details]
Patch

Attachment 213994 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/3954167
Comment 3 Build Bot 2013-10-11 11:01:25 PDT 
Comment on attachment 213994 [details]
Patch

Attachment 213994 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/3950163
Comment 4 Ryosuke Niwa 2013-10-11 11:11:57 PDT 
It seems like gesture event is enabled by default on Mac port.
Are you sure we want to remove this?
Comment 5 Ryosuke Niwa 2013-10-11 11:12:29 PDT 
Also, it seems like this patch warrants a webkit-dev announcement.
Comment 6 Ryosuke Niwa 2013-10-11 11:29:44 PDT 
This has been announced on webkit-dev:
https://lists.webkit.org/pipermail/webkit-dev/2013-October/025673.html
Comment 7 Ryosuke Niwa 2013-10-11 11:30:29 PDT 
Comment on attachment 213994 [details]
Patch

rs=me but please fix the Mac build. PlatformGestureEvent.h is included in ScrollAnimatorMac.mm.
Comment 8 Build Bot 2013-10-11 12:08:28 PDT 
Comment on attachment 213994 [details]
Patch

Attachment 213994 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/3946188
Comment 9 Anders Carlsson 2013-10-11 12:16:39 PDT 
Committed r157316: <http://trac.webkit.org/changeset/157316>