Bug 122650

Summary: Remove gesture event support from WebCore
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cmarcelo, commit-queue, esprehn+autocc, gyuyoung.kim, kangil.han, rakuco, rniwa
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+, buildbot: commit-queue-

Anders Carlsson
Reported 2013-10-11 09:44:18 PDT
Remove gesture event support from WebCore
Attachments
Patch (51.05 KB, patch)
2013-10-11 09:50 PDT, Anders Carlsson 		rniwa: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-10-11 09:50:01 PDT
Created attachment 213994 [details] Patch
Build Bot
Comment 2 2013-10-11 10:26:15 PDT
Comment on attachment 213994 [details] Patch Attachment 213994 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3954167
Build Bot
Comment 3 2013-10-11 11:01:25 PDT
Comment on attachment 213994 [details] Patch Attachment 213994 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3950163
Ryosuke Niwa
Comment 4 2013-10-11 11:11:57 PDT
It seems like gesture event is enabled by default on Mac port. Are you sure we want to remove this?
Ryosuke Niwa
Comment 5 2013-10-11 11:12:29 PDT
Also, it seems like this patch warrants a webkit-dev announcement.
Ryosuke Niwa
Comment 6 2013-10-11 11:29:44 PDT
This has been announced on webkit-dev: https://lists.webkit.org/pipermail/webkit-dev/2013-October/025673.html
Ryosuke Niwa
Comment 7 2013-10-11 11:30:29 PDT
Comment on attachment 213994 [details] Patch rs=me but please fix the Mac build. PlatformGestureEvent.h is included in ScrollAnimatorMac.mm.
Build Bot
Comment 8 2013-10-11 12:08:28 PDT
Comment on attachment 213994 [details] Patch Attachment 213994 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3946188
Anders Carlsson
Comment 9 2013-10-11 12:16:39 PDT
Committed r157316: <http://trac.webkit.org/changeset/157316>
Note You need to log in before you can comment on or make changes to this bug.