Bug 122641

Summary: Remove some dead code from PlatformCALayer*
Product: WebKit Reporter: Tim Horton <thorton>
Component: Layout and RenderingAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
buildbot: commit-queue-
patch none

Tim Horton
Reported 2013-10-10 23:31:47 PDT
There are a bunch of unused getters in PlatformCALayer that we should get rid of before refactoring. Ideally PlatformCALayer would be nearly entirely write-only, but our layer-cloning code poses some problems there.
Attachments
patch (11.21 KB, patch)
2013-10-10 23:44 PDT, Tim Horton 		buildbot: commit-queue-
DetailsFormatted DiffDiff
patch (11.75 KB, patch)
2013-10-11 03:42 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-10-10 23:44:17 PDT
Created attachment 213972 [details] patch
Tim Horton
Comment 2 2013-10-10 23:44:37 PDT
Ugh, no Win EWS?
Build Bot
Comment 3 2013-10-11 00:25:52 PDT
Comment on attachment 213972 [details] patch Attachment 213972 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/3898009
Tim Horton
Comment 4 2013-10-11 03:42:54 PDT
Created attachment 213979 [details] patch
WebKit Commit Bot
Comment 5 2013-10-11 12:03:02 PDT
Comment on attachment 213979 [details] patch Clearing flags on attachment: 213979 Committed r157314: <http://trac.webkit.org/changeset/157314>
WebKit Commit Bot
Comment 6 2013-10-11 12:03:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.