Bug 122616

Summary:

CallbackData unnecessarily caches the JSValue for currentThis

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Mark Hahnenberg

Reported 2013-10-10 13:01:26 PDT

CallbackData implements its own version of caching the JSValue* for the JSValueRef it stores. +[JSValue valueWithJSValueRef:inContext:] already does caching, thus obviating the need for CallbackData to do its own caching.

Attachments
Patch (3.08 KB, patch) 2013-10-10 13:08 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mark Hahnenberg

Comment 1 2013-10-10 13:08:04 PDT

Created attachment 213919 [details] Patch

WebKit Commit Bot

Comment 2 2013-10-10 13:48:48 PDT

Comment on attachment 213919 [details] Patch Clearing flags on attachment: 213919 Committed r157249: <http://trac.webkit.org/changeset/157249>

WebKit Commit Bot

Comment 3 2013-10-10 13:48:50 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.