Bug 122616

Summary:

CallbackData unnecessarily caches the JSValue for currentThis

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Mark Hahnenberg 2013-10-10 13:01:26 PDT

CallbackData implements its own version of caching the JSValue* for the JSValueRef it stores. +[JSValue valueWithJSValueRef:inContext:] already does caching, thus obviating the need for CallbackData to do its own caching.

Comment 1 Mark Hahnenberg 2013-10-10 13:08:04 PDT

Created attachment 213919 [details]
Patch

Comment 2 WebKit Commit Bot 2013-10-10 13:48:48 PDT

Comment on attachment 213919 [details]
Patch

Clearing flags on attachment: 213919

Committed r157249: <http://trac.webkit.org/changeset/157249>

Comment 3 WebKit Commit Bot 2013-10-10 13:48:50 PDT

All reviewed patches have been landed.  Closing bug.