Bug 122601

Summary: [CSS Shapes] clampToUnsigned() should return unsigned, not int
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, esprehn+autocc, glenn, kling, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 121619    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Hans Muller
Reported 2013-10-10 08:34:24 PDT
The patch for https://bugs.webkit.org/show_bug.cgi?id=121619 included a MathExtras.h clampToUnsigned() inline. I'd mistakenly given it an "int" return type. Of course the return type should be unsigned.
Attachments
Patch (2.63 KB, patch)
2013-10-10 09:47 PDT, Hans Muller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2013-10-10 09:47:48 PDT
Created attachment 213893 [details] Patch Corrected clampToUnsigned().
WebKit Commit Bot
Comment 2 2013-10-10 12:21:27 PDT
Comment on attachment 213893 [details] Patch Clearing flags on attachment: 213893 Committed r157238: <http://trac.webkit.org/changeset/157238>
WebKit Commit Bot
Comment 3 2013-10-10 12:21:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.