Summary: | Move inheritance of PopupMenuClient from RenderSearchField to RenderTextControlSingleLine | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | ChangSeok Oh <changseok> | ||||||
Component: | Forms | Assignee: | ChangSeok Oh <changseok> | ||||||
Status: | RESOLVED INVALID | ||||||||
Severity: | Normal | CC: | andersca, buildbot, gustavo, kling, rniwa | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 98934 | ||||||||
Attachments: |
|
Description
ChangSeok Oh
2013-10-10 01:13:16 PDT
Created attachment 213973 [details]
Patch
Comment on attachment 213973 [details] Patch Attachment 213973 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3953033 Comment on attachment 213973 [details] Patch Attachment 213973 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3946029 Created attachment 213976 [details]
Patch
Comment on attachment 213976 [details]
Patch
I don't feel qualified to judge whether this change makes sense on its merits, but I think it would be better to have the patch be the actual functional change instead of just the ground work.
The approach is changed not to use GtkPopup |