Bug 122586

Summary:

Move the rest of EventRetargeter functions to EventPath

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

New Bugs

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, darin, eflews.bot, esprehn+autocc, gyuyoung.kim, kangil.han, kling, koivisto, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Cleanup	none
Updated for ToT	none
Fixed EFL build	none
Another EFL build fix	none
Yet another EFL build fix	kling: review+, commit-queue: commit-queue-

Ryosuke Niwa

Reported 2013-10-09 20:18:22 PDT

Move the rest of EventRetargeter functions to EventPath

Attachments
Cleanup (13.36 KB, patch) 2013-10-09 20:23 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Updated for ToT (13.41 KB, patch) 2013-10-09 20:27 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Fixed EFL build (13.39 KB, patch) 2013-10-09 21:18 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Another EFL build fix (13.40 KB, patch) 2013-10-09 21:34 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Yet another EFL build fix (13.40 KB, patch) 2013-10-09 21:53 PDT, Ryosuke Niwa	kling: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2013-10-09 20:23:32 PDT

Created attachment 213846 [details] Cleanup

Ryosuke Niwa

Comment 2 2013-10-09 20:27:06 PDT

Created attachment 213847 [details] Updated for ToT

EFL EWS Bot

Comment 3 2013-10-09 20:47:26 PDT

Comment on attachment 213847 [details] Updated for ToT Attachment 213847 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3848042

EFL EWS Bot

Comment 4 2013-10-09 20:53:17 PDT

Comment on attachment 213847 [details] Updated for ToT Attachment 213847 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/3525125

Ryosuke Niwa

Comment 5 2013-10-09 21:18:44 PDT

Created attachment 213849 [details] Fixed EFL build

EFL EWS Bot

Comment 6 2013-10-09 21:21:35 PDT

Comment on attachment 213849 [details] Fixed EFL build Attachment 213849 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3558123

EFL EWS Bot

Comment 7 2013-10-09 21:23:14 PDT

Comment on attachment 213849 [details] Fixed EFL build Attachment 213849 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/3662030

Ryosuke Niwa

Comment 8 2013-10-09 21:34:44 PDT

Created attachment 213850 [details] Another EFL build fix

Ryosuke Niwa

Comment 9 2013-10-09 21:53:22 PDT

Created attachment 213852 [details] Yet another EFL build fix

WebKit Commit Bot

Comment 10 2013-10-10 01:25:58 PDT

Comment on attachment 213852 [details] Yet another EFL build fix Rejecting attachment 213852 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 213852, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: d at 165 (offset 60 lines). Hunk #3 succeeded at 175 (offset 60 lines). Hunk #4 FAILED at 255. 1 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/dom/EventDispatcher.cpp.rej patching file Source/WebCore/dom/EventDispatcher.h patching file Source/WebCore/dom/EventRetargeter.cpp patching file Source/WebCore/dom/EventRetargeter.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Andreas Kling']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/3485190

Ryosuke Niwa

Comment 11 2013-10-10 12:47:59 PDT

Committed r157242: <http://trac.webkit.org/changeset/157242>

Note You need to log in before you can comment on or make changes to this bug.