Bug 122543

Summary: [CSSRegions] Use RenderStyle::hasFlowFrom when needed
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: abucur, allan.jensen, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kangil.han, kondapallykalyan, macpherson, menard, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch 2
none
Patch for landing none

Mihnea Ovidenie
Reported 2013-10-09 01:24:52 PDT
Instead of direct checks for !style()->regionThread().isNull().
Attachments
Patch (4.26 KB, patch)
2013-10-09 01:27 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch 2 (5.88 KB, patch)
2013-10-09 02:11 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.21 KB, patch)
2013-10-22 00:23 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2013-10-09 01:27:27 PDT
Created attachment 213762 [details] Patch
Andrei Bucur
Comment 2 2013-10-09 01:33:13 PDT
I think "hasFlowFrom" is a better function name. It's also in line with existing accessors like "hasOpacity, hasPadding" etc.
Mihnea Ovidenie
Comment 3 2013-10-09 02:11:39 PDT
Created attachment 213764 [details] Patch 2
Mihnea Ovidenie
Comment 4 2013-10-09 02:48:21 PDT
(In reply to comment #2) > I think "hasFlowFrom" is a better function name. It's also in line with existing accessors like "hasOpacity, hasPadding" etc. Agree, maybe we should also change RenderStyle members m_regionThread to m_flowFrom.
Dave Hyatt
Comment 5 2013-10-21 12:17:28 PDT
Comment on attachment 213764 [details] Patch 2 r=me
Mihnea Ovidenie
Comment 6 2013-10-22 00:23:13 PDT
Created attachment 214825 [details] Patch for landing
WebKit Commit Bot
Comment 7 2013-10-22 01:26:31 PDT
Comment on attachment 214825 [details] Patch for landing Clearing flags on attachment: 214825 Committed r157779: <http://trac.webkit.org/changeset/157779>
WebKit Commit Bot
Comment 8 2013-10-22 01:26:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.