Bug 122525

Summary: Refined power management in SunSpider 1.0.2
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, fpizlo, mjs, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
barraclough: review+
Upload changes to webkit.org barraclough: review+

Geoffrey Garen
Reported 2013-10-08 14:38:50 PDT
Refined power management in SunSpider 1.0.2
Attachments
Patch (4.67 KB, patch)
2013-10-08 14:47 PDT, Geoffrey Garen 		barraclough: review+
DetailsFormatted DiffDiff
Upload changes to webkit.org (26.64 KB, patch)
2013-10-08 14:54 PDT, Geoffrey Garen 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2013-10-08 14:47:26 PDT
Created attachment 213721 [details] Patch
Geoffrey Garen
Comment 2 2013-10-08 14:54:28 PDT
Created attachment 213722 [details] Upload changes to webkit.org
Gavin Barraclough
Comment 3 2013-10-08 15:17:29 PDT
Comment on attachment 213721 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213721&action=review > PerformanceTests/SunSpider/resources/driver-TEMPLATE.html:60 > +function next() Bonus space! > PerformanceTests/SunSpider/resources/driver-TEMPLATE.html:71 > + for (var start = new Date; new Date - start < warmup; ) { } This busy loop will churn through a lot of object creation – I wonder if it might be worth having a loop body containing math to spin up the CPU without also creating artificial GC pressure?
Geoffrey Garen
Comment 4 2013-10-08 15:38:41 PDT
Committed r157140: <http://trac.webkit.org/changeset/157140>
Geoffrey Garen
Comment 5 2013-10-08 15:38:53 PDT
Committed r157141: <http://trac.webkit.org/changeset/157141>
Note You need to log in before you can comment on or make changes to this bug.