Bug 122517

Summary: [MediaStream] Fix segfault in initializeMockSources()
Product: WebKit Reporter: Lauro Moura Maranhao Neto <lauro.neto>
Component: WebCore Misc.Assignee: Lauro Moura Maranhao Neto <lauro.neto>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn, jer.noble
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Lauro Moura Maranhao Neto
Reported 2013-10-08 12:47:33 PDT
MockMediaStreamCenter.cpp initializeMockSources() tries to add a RefPtr<MockSource> to a HashMap by releasing it and also access a member function (id) in the same call. If the release() is evaluated before id(), a segfault occurs.
Attachments
Patch (2.27 KB, patch)
2013-10-08 12:52 PDT, Lauro Moura Maranhao Neto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lauro Moura Maranhao Neto
Comment 1 2013-10-08 12:52:42 PDT
Created attachment 213709 [details] Patch
WebKit Commit Bot
Comment 2 2013-10-08 13:29:10 PDT
Comment on attachment 213709 [details] Patch Clearing flags on attachment: 213709 Committed r157132: <http://trac.webkit.org/changeset/157132>
WebKit Commit Bot
Comment 3 2013-10-08 13:29:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.