Bug 122513
Summary: | [CSS Shapes] Floats should be positioned based on the margin box inside shape-inside | ||
---|---|---|---|
Product: | WebKit | Reporter: | Zoltan Horvath <zoltan> |
Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED LATER | ||
Severity: | Normal | CC: | bjonesbe |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | |||
Bug Blocks: | 121615 |
Zoltan Horvath
Currently, the shape-inside floats implementation doesn't deal with floats with margins/borders. Floats should be positioned based on the border box. (See Bem's comment: https://bugs.webkit.org/show_bug.cgi?id=121616#c7)
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Bem Jones-Bey
(In reply to comment #0)
> Currently, the shape-inside floats implementation doesn't deal with floats with margins/borders. Floats should be positioned based on the border box. (See Bem's comment: https://bugs.webkit.org/show_bug.cgi?id=121616#c7)
You mean floats should be positioned based on the margin box. (which is the dimensions you get when you use the logicalHeight/Width, etc of FloatingObject)
I was confused by your change, since you changed it from using the FloatingObject height/width to using the RenderBox's height/width, and I wasn't sure why.