Bug 122492

Summary: [Mac] Change NetscapePluginInstanceProxy::m_replies to use unique_ptr instead of deleteAllValues
Product: WebKit Reporter: Darin Adler <darin>
Component: Plug-insAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Bug Depends on:    
Bug Blocks: 73757    
Attachments:
Description Flags
Patch none

Darin Adler
Reported 2013-10-07 23:47:02 PDT
Change NetscapePluginInstanceProxy::m_replies to use unique_ptr instead of deleteAllValues
Attachments
Patch (24.36 KB, patch)
2013-10-07 23:53 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-10-07 23:53:42 PDT
Created attachment 213663 [details] Patch
Andreas Kling
Comment 2 2013-10-08 00:00:38 PDT
Comment on attachment 213663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213663&action=review r=me > Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.h:254 > - m_replies.set(requestID, reply); > + m_replies.add(requestID, std::move(reply)); Nice.
WebKit Commit Bot
Comment 3 2013-10-08 00:44:19 PDT
Comment on attachment 213663 [details] Patch Clearing flags on attachment: 213663 Committed r157089: <http://trac.webkit.org/changeset/157089>
WebKit Commit Bot
Comment 4 2013-10-08 00:44:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.