Bug 122489

Summary: [Media] Refactor supportsType() factory method to take a parameters object.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eric.carlson, philn, rniwa, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jer Noble
Reported 2013-10-07 22:11:41 PDT
[Media] Refactor supportsType() factory method to take a parameters object.
Attachments
Patch (23.82 KB, patch)
2013-10-07 22:16 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (31.57 KB, patch)
2013-10-07 23:39 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (31.61 KB, patch)
2013-10-08 07:58 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2013-10-07 22:16:33 PDT
Created attachment 213655 [details] Patch
Jer Noble
Comment 2 2013-10-07 23:39:33 PDT
Created attachment 213661 [details] Patch
Build Bot
Comment 3 2013-10-08 00:12:34 PDT
Comment on attachment 213661 [details] Patch Attachment 213661 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3708112
Build Bot
Comment 4 2013-10-08 00:23:12 PDT
Comment on attachment 213661 [details] Patch Attachment 213661 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3715126
Jer Noble
Comment 5 2013-10-08 07:58:40 PDT
Created attachment 213686 [details] Patch
Eric Carlson
Comment 6 2013-10-21 22:57:06 PDT
Comment on attachment 213686 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213686&action=review > Source/WebCore/platform/graphics/MediaPlayer.cpp:405 > + parameters.isMediaSource = !!m_mediaSource; We will want to use this for other features (eg. MediaStream), so an enum would be better than a Boolean here.
WebKit Commit Bot
Comment 7 2013-10-22 17:12:58 PDT
Comment on attachment 213686 [details] Patch Clearing flags on attachment: 213686 Committed r157834: <http://trac.webkit.org/changeset/157834>
WebKit Commit Bot
Comment 8 2013-10-22 17:13:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.