Bug 122483

Summary: EventDispatchBehavior is unnecessary
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: EvangelismAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, commit-queue, esprehn+autocc, kangil.han, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup
none
Patch for landing none

Ryosuke Niwa
Reported 2013-10-07 20:53:45 PDT
EventDispatchBehavior is unnecessary
Attachments
Cleanup (4.76 KB, patch)
2013-10-07 20:54 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.14 KB, patch)
2013-10-07 21:14 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-10-07 20:54:43 PDT
Created attachment 213648 [details] Cleanup
Andreas Kling
Comment 2 2013-10-07 21:05:44 PDT
Comment on attachment 213648 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=213648&action=review r=me. > Source/WebCore/dom/EventRetargeter.cpp:38 > +static inline bool shouldEventCrossShadowBoundary(Event* event, ShadowRoot* shadowRoot, EventTarget* target) All three parameters should be references. > Source/WebCore/dom/EventRetargeter.cpp:48 > + if (element->isMediaElement() && shadowRoot && shadowRoot->hostElement() == element) 'shadowRoot' is already null-checked by the caller. > Source/WebCore/dom/EventRetargeter.cpp:58 > + bool tagetIsInShadowRoot = targetNode && targetNode->treeScope().rootNode() == shadowRoot; Typo, taget -> target.
Ryosuke Niwa
Comment 3 2013-10-07 21:14:17 PDT
Created attachment 213650 [details] Patch for landing
WebKit Commit Bot
Comment 4 2013-10-07 21:42:46 PDT
Comment on attachment 213650 [details] Patch for landing Clearing flags on attachment: 213650 Committed r157085: <http://trac.webkit.org/changeset/157085>
WebKit Commit Bot
Comment 5 2013-10-07 21:42:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.