Bug 122477

Summary: Make buildRelatedNodeMap and findRelatedNode static to EventRetargeter.cpp
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: UI EventsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, commit-queue, esprehn+autocc, kangil.han, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup
none
Minor bug fix koivisto: review+

Ryosuke Niwa
Reported 2013-10-07 18:17:12 PDT
Make buildRelatedNodeMap and findRelatedNode static to EventRetargeter.cpp
Attachments
Cleanup (7.05 KB, patch)
2013-10-07 18:23 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Minor bug fix (7.46 KB, patch)
2013-10-07 18:26 PDT, Ryosuke Niwa 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-10-07 18:23:01 PDT
Created attachment 213636 [details] Cleanup
Ryosuke Niwa
Comment 2 2013-10-07 18:26:36 PDT
Created attachment 213637 [details] Minor bug fix
Antti Koivisto
Comment 3 2013-10-07 18:32:07 PDT
Comment on attachment 213637 [details] Minor bug fix View in context: https://bugs.webkit.org/attachment.cgi?id=213637&action=review > Source/WebCore/dom/EventRetargeter.cpp:184 > +static void buildRelatedNodeMap(const Node* relatedNode, HashMap<TreeScope*, Node*>& relatedNodeMap) I wish these had more descriptive names. Related to what and how? Same applies to variable names in this code. > Source/WebCore/dom/EventRetargeter.h:65 > typedef Vector<RefPtr<Node> > AdjustedNodes; Would be nice to remove this opaque typedef too.
Ryosuke Niwa
Comment 4 2013-10-07 19:03:03 PDT
Comment on attachment 213637 [details] Minor bug fix View in context: https://bugs.webkit.org/attachment.cgi?id=213637&action=review >> Source/WebCore/dom/EventRetargeter.cpp:184 >> +static void buildRelatedNodeMap(const Node* relatedNode, HashMap<TreeScope*, Node*>& relatedNodeMap) > > I wish these had more descriptive names. Related to what and how? Same applies to variable names in this code. I think they're referring to https://developer.mozilla.org/en-US/docs/Web/API/event.relatedTarget but I agree it'll be nice if we could come up with a better name.
Ryosuke Niwa
Comment 5 2013-10-07 20:38:01 PDT
Committed r157083: <http://trac.webkit.org/changeset/157083>
Note You need to log in before you can comment on or make changes to this bug.