Summary: | [ATK] Support compilation of EFL/GTK without accessibility | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Krzysztof Czech <k.czech> | ||||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cfleizach, commit-queue, gyuyoung.kim, mario, rakuco, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Krzysztof Czech
2013-10-07 06:58:21 PDT
Created attachment 213580 [details]
Patch
Created attachment 213581 [details]
Patch
Comment on attachment 213581 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213581&action=review > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1434 > +namespace WTR { Is there code like this already inside AccessibilityUIElement.cpp? > (From update of attachment 213581 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=213581&action=review
>
> > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1434
> > +namespace WTR {
>
> Is there code like this already inside AccessibilityUIElement.cpp?
Yes there is, you mean it could be reused ?.
Sounds good, I will check this.
Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1434
> > > +namespace WTR {
> >
> > Is there code like this already inside AccessibilityUIElement.cpp?
> Yes there is, you mean it could be reused ?.
> Sounds good, I will check this.
It could be reused as well as I guess bits from AccessibilityUIController.cpp
Line #if !PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL) in AccessibilityUIElement.cpp
can be changed to
#if (!PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL)) || !HAVE(ACCESSIBILITY)
but then respective mac files should have #if HAVE(ACCESSIBILITY) added, otherwise when accessibility is disabled, redefinition conflicts will happen.
(In reply to comment #6) > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1434 > > > > +namespace WTR { > > > > > > Is there code like this already inside AccessibilityUIElement.cpp? > > Yes there is, you mean it could be reused ?. > > Sounds good, I will check this. > > It could be reused as well as I guess bits from AccessibilityUIController.cpp > Line #if !PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL) in AccessibilityUIElement.cpp > can be changed to > #if (!PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL)) || !HAVE(ACCESSIBILITY) > > but then respective mac files should have #if HAVE(ACCESSIBILITY) added, otherwise when accessibility is disabled, redefinition conflicts will happen. I think we should re-use these. I don't want to have to maintain two long lists of unsupported functions when adding to DRT Created attachment 216655 [details]
patch
(In reply to comment #7) > (In reply to comment #6) > > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1434 > > > > > +namespace WTR { > > > > > > > > Is there code like this already inside AccessibilityUIElement.cpp? > > > Yes there is, you mean it could be reused ?. > > > Sounds good, I will check this. > > > > It could be reused as well as I guess bits from AccessibilityUIController.cpp > > Line #if !PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL) in AccessibilityUIElement.cpp > > can be changed to > > #if (!PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL)) || !HAVE(ACCESSIBILITY) > > > > but then respective mac files should have #if HAVE(ACCESSIBILITY) added, otherwise when accessibility is disabled, redefinition conflicts will happen. > > I think we should re-use these. I don't want to have to maintain two long lists of unsupported functions when adding to DRT Yes, you are right in terms of maintenance, this would not be a good idea to support it. Thanks for the suggestion. I already prepared a new patch. Comment on attachment 216655 [details] patch Clearing flags on attachment: 216655 Committed r159181: <http://trac.webkit.org/changeset/159181> All reviewed patches have been landed. Closing bug. |