Bug 122439

Summary: Add OVERRIDE and virtual where appropriate
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: eflews.bot, gtk-ews, gyuyoung.kim, rego+ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch koivisto: review+

Anders Carlsson
Reported 2013-10-06 21:59:18 PDT
Add OVERRIDE and virtual where appropriate
Attachments
Patch (454.33 KB, patch)
2013-10-06 22:24 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (454.36 KB, patch)
2013-10-07 08:15 PDT, Anders Carlsson 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-10-06 22:24:20 PDT
Created attachment 213564 [details] Patch
EFL EWS Bot
Comment 2 2013-10-06 22:41:22 PDT
Comment on attachment 213564 [details] Patch Attachment 213564 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3565002
EFL EWS Bot
Comment 3 2013-10-06 22:45:31 PDT
Comment on attachment 213564 [details] Patch Attachment 213564 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/3381007
Build Bot
Comment 4 2013-10-06 23:12:37 PDT
Comment on attachment 213564 [details] Patch Attachment 213564 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/3473036
kov's GTK+ EWS bot
Comment 5 2013-10-07 00:31:24 PDT
Comment on attachment 213564 [details] Patch Attachment 213564 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/3356126
Anders Carlsson
Comment 6 2013-10-07 08:15:59 PDT
Created attachment 213585 [details] Patch
Anders Carlsson
Comment 7 2013-10-07 09:25:23 PDT
Committed r157044: <http://trac.webkit.org/changeset/157044>
Note You need to log in before you can comment on or make changes to this bug.