Bug 122439 - Add OVERRIDE and virtual where appropriate
Summary: Add OVERRIDE and virtual where appropriate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-06 21:59 PDT by Anders Carlsson
Modified: 2013-10-07 09:25 PDT (History)
5 users (show)

See Also:


Attachments
Patch (454.33 KB, patch)
2013-10-06 22:24 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (454.36 KB, patch)
2013-10-07 08:15 PDT, Anders Carlsson
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-10-06 21:59:18 PDT
Add OVERRIDE and virtual where appropriate
Comment 1 Anders Carlsson 2013-10-06 22:24:20 PDT
Created attachment 213564 [details]
Patch
Comment 2 EFL EWS Bot 2013-10-06 22:41:22 PDT
Comment on attachment 213564 [details]
Patch

Attachment 213564 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3565002
Comment 3 EFL EWS Bot 2013-10-06 22:45:31 PDT
Comment on attachment 213564 [details]
Patch

Attachment 213564 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/3381007
Comment 4 Build Bot 2013-10-06 23:12:37 PDT
Comment on attachment 213564 [details]
Patch

Attachment 213564 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3473036
Comment 5 kov's GTK+ EWS bot 2013-10-07 00:31:24 PDT
Comment on attachment 213564 [details]
Patch

Attachment 213564 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/3356126
Comment 6 Anders Carlsson 2013-10-07 08:15:59 PDT
Created attachment 213585 [details]
Patch
Comment 7 Anders Carlsson 2013-10-07 09:25:23 PDT
Committed r157044: <http://trac.webkit.org/changeset/157044>