| Summary: | Factor text paint style computation out from InlineTextBox | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, kling, kondapallykalyan, philn, rakuco, rniwa, xan.lopez | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Antti Koivisto
2013-10-06 18:03:26 PDT
Created attachment 213547 [details]
patch
Comment on attachment 213547 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=213547&action=review > Source/WebCore/rendering/TextPaintStyle.cpp:38 > +TextPaintStyle::TextPaintStyle() I would zero-initialize the stroke width here for good measure. > Source/WebCore/rendering/TextPaintStyle.h:54 > +void updateGraphicsContext(GraphicsContext*, const TextPaintStyle&, StrokeColorType = UseNormalStrokeColor); This should take a GraphicsContext&. Comment on attachment 213547 [details] patch Attachment 213547 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3513054 Comment on attachment 213547 [details] patch Attachment 213547 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3368046 Comment on attachment 213547 [details] patch Attachment 213547 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/3519060 Created attachment 213549 [details]
for bots
|