Bug 122433

Summary: Factor text paint style computation out from InlineTextBox
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, kling, kondapallykalyan, philn, rakuco, rniwa, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
kling: review+, eflews.bot: commit-queue-
for bots none

Antti Koivisto
Reported 2013-10-06 18:03:26 PDT
for the future
Attachments
patch (33.37 KB, patch)
2013-10-06 18:06 PDT, Antti Koivisto 		kling: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
for bots (33.43 KB, patch)
2013-10-06 18:40 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-10-06 18:06:08 PDT
Created attachment 213547 [details] patch
Andreas Kling
Comment 2 2013-10-06 18:13:18 PDT
Comment on attachment 213547 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=213547&action=review > Source/WebCore/rendering/TextPaintStyle.cpp:38 > +TextPaintStyle::TextPaintStyle() I would zero-initialize the stroke width here for good measure. > Source/WebCore/rendering/TextPaintStyle.h:54 > +void updateGraphicsContext(GraphicsContext*, const TextPaintStyle&, StrokeColorType = UseNormalStrokeColor); This should take a GraphicsContext&.
EFL EWS Bot
Comment 3 2013-10-06 18:25:24 PDT
Comment on attachment 213547 [details] patch Attachment 213547 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3513054
Build Bot
Comment 4 2013-10-06 18:33:31 PDT
Comment on attachment 213547 [details] patch Attachment 213547 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3368046
EFL EWS Bot
Comment 5 2013-10-06 18:38:43 PDT
Comment on attachment 213547 [details] patch Attachment 213547 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/3519060
Antti Koivisto
Comment 6 2013-10-06 18:40:47 PDT
Created attachment 213549 [details] for bots
Antti Koivisto
Comment 7 2013-10-06 19:16:06 PDT
https://trac.webkit.org/r157015
Note You need to log in before you can comment on or make changes to this bug.