Bug 122432

Summary: Improve HashMap::add comment and other similar comments
Product: WebKit Reporter: Darin Adler <darin>
Component: New BugsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, markcarltonn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Darin Adler
Reported 2013-10-06 17:03:01 PDT
Improve HashMap::add comment and other similar comments
Attachments
Patch (4.29 KB, patch)
2013-10-06 17:03 PDT, Darin Adler 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-10-06 17:03:31 PDT
Created attachment 213542 [details] Patch
Andreas Kling
Comment 2 2013-10-06 17:34:22 PDT
Comment on attachment 213542 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213542&action=review r=me with some suggestions from a non-native speaker: > Source/WTF/wtf/HashCountedSet.h:60 > + // Increases the count if an equal value is already present. Increases -> Increments > Source/WTF/wtf/HashCountedSet.h:62 > + // and an isNewEntry bool that indicates if it is a new or existing entry. I'd say "indicates whether" rather than "indicates if" > Source/WTF/wtf/HashCountedSet.h:65 > + // Reduces the count of the value, and removes it if count goes down to zero. Reduces -> Decrements
Darin Adler
Comment 3 2013-10-07 18:57:58 PDT
Committed r157077: <http://trac.webkit.org/changeset/157077>
Note You need to log in before you can comment on or make changes to this bug.