Summary: | Improve HashMap::add comment and other similar comments | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
Component: | New Bugs | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, cmarcelo, commit-queue, markcarltonn | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Darin Adler
2013-10-06 17:03:01 PDT
Created attachment 213542 [details]
Patch
Comment on attachment 213542 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213542&action=review r=me with some suggestions from a non-native speaker: > Source/WTF/wtf/HashCountedSet.h:60 > + // Increases the count if an equal value is already present. Increases -> Increments > Source/WTF/wtf/HashCountedSet.h:62 > + // and an isNewEntry bool that indicates if it is a new or existing entry. I'd say "indicates whether" rather than "indicates if" > Source/WTF/wtf/HashCountedSet.h:65 > + // Reduces the count of the value, and removes it if count goes down to zero. Reduces -> Decrements Committed r157077: <http://trac.webkit.org/changeset/157077> |