| Summary: | Make Vector::insert work for move-only types | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
| Component: | Web Template Framework | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, ap, benjamin, bw80.lee, cmarcelo, commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Darin Adler
2013-10-06 16:16:45 PDT
Created attachment 213536 [details]
Patch
Attachment 213536 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Vector.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/history/HistoryItem.cpp']" exit_code: 1
Source/WTF/wtf/Vector.h:647: Missing spaces around && [whitespace/operators] [3]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 213536 [details]
Patch
Patch looks good, but where's the API test?
Is there a requirement to have unit tests for WTF? I don't remember any discussion that resulted in support for such. (In reply to comment #4) > Is there a requirement to have unit tests for WTF? I don't remember any discussion that resulted in support for such. I’ve been adding unit tests as I’ve been implementing the move-only functionality of WTF data structures. Comment on attachment 213536 [details]
Patch
OK, I’ll upload a new patch with unit tests when I have some time to work on this.
Comment on attachment 213536 [details]
Patch
Nah, let’s land this. It was blocking a change Samsung want to make to their WorkQueue implementation.
Comment on attachment 213536 [details] Patch Clearing flags on attachment: 213536 Committed r157074: <http://trac.webkit.org/changeset/157074> All reviewed patches have been landed. Closing bug. |