Bug 122414 – context-menu-suggestions-multiword-selection.html and context-menu-suggestions-subword-selection.html are flaky after r156901

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

The following layout test is very flaky on Mac.

editing/spelling/context-menu-suggestions-multiword-selection.html

This started with <http://trac.webkit.org/changeset/156901>.

http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fspelling%2Fcontext-menu-suggestions-multiword-selection.html

[Alexey Proskuryakov]

Marked as flaky in r156990.

[Grzegorz Czajkowski]

Committed r157034: <http://trac.webkit.org/changeset/157034>

[Grzegorz Czajkowski]

Marked as flaky context-menu-suggestions-subword-selection.html too. It started failing for Mac similarly to context-menu-suggestions-multiword-selection.html.

[Grzegorz Czajkowski]

Created attachment 213579 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 213579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213579&action=review

> LayoutTests/editing/spelling/resources/util.js:28
> +    }, true /* Doesn't produce logs on success. */ );

I think it's fine to output this. We just need to rebaseline the tests.

[Grzegorz Czajkowski]

(In reply to comment #5)
> (From update of attachment 213579 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=213579&action=review
> 
> > LayoutTests/editing/spelling/resources/util.js:28
> > +    }, true /* Doesn't produce logs on success. */ );
> 
> I think it's fine to output this. We just need to rebaseline the tests.

Sure, will do that before landing. We should be aware that more spellchecking tests include utils.js and those need to be rebaselined too.

[Grzegorz Czajkowski]

Committed r157094: <http://trac.webkit.org/changeset/157094>