Bug 122410

Summary:

Don't try to dispatch resize events for SVG images

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, kling, kondapallykalyan, pdr, schenney, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

122371

Attachments:

Description	Flags
patch	darin: review+

Description Antti Koivisto 2013-10-06 05:02:55 PDT

SVG images have scripting disabled but we still try to dispatch resize events.

Comment 1 Antti Koivisto 2013-10-06 05:14:02 PDT

Created attachment 213509 [details]
patch

Comment 2 Darin Adler 2013-10-06 09:32:31 PDT

Comment on attachment 213509 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213509&action=review

r=me if you add a null check for page or explain why it's not needed

> Source/WebCore/page/FrameView.cpp:2773
> +    if (frame().page()->chrome().client().isSVGImageChromeClient())
> +        return;

What guarantees that page is non-null?

Comment 3 Antti Koivisto 2013-10-06 15:27:35 PDT

https://trac.webkit.org/r157010

Comment 4 Antti Koivisto 2013-10-06 15:29:39 PDT

(In reply to comment #2)
> What guarantees that page is non-null?

Uh, some similar looking functions don't check it either... Added the check.