Bug 122410

Summary: Don't try to dispatch resize events for SVG images
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, kling, kondapallykalyan, pdr, schenney, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 122371    
Attachments:
Description Flags
patch darin: review+

Antti Koivisto
Reported 2013-10-06 05:02:55 PDT
SVG images have scripting disabled but we still try to dispatch resize events.
Attachments
patch (3.20 KB, patch)
2013-10-06 05:14 PDT, Antti Koivisto 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-10-06 05:14:02 PDT
Created attachment 213509 [details] patch
Darin Adler
Comment 2 2013-10-06 09:32:31 PDT
Comment on attachment 213509 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=213509&action=review r=me if you add a null check for page or explain why it's not needed > Source/WebCore/page/FrameView.cpp:2773 > + if (frame().page()->chrome().client().isSVGImageChromeClient()) > + return; What guarantees that page is non-null?
Antti Koivisto
Comment 3 2013-10-06 15:27:35 PDT
https://trac.webkit.org/r157010
Antti Koivisto
Comment 4 2013-10-06 15:29:39 PDT
(In reply to comment #2) > What guarantees that page is non-null? Uh, some similar looking functions don't check it either... Added the check.
Note You need to log in before you can comment on or make changes to this bug.