Bug 122390

Summary: Remove unneeded ScriptGCEvent class
Product: WebKit Reporter: Darin Adler <darin>
Component: WebCore JavaScriptAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eflews.bot, gyuyoung.kim, rakuco, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
andersca: review+, commit-queue: commit-queue-
Patch none

Description Darin Adler 2013-10-05 11:53:41 PDT 
Remove unneeded ScriptGCEvent class
Comment 1 Darin Adler 2013-10-05 12:02:31 PDT 
*** Bug 122391 has been marked as a duplicate of this bug. ***
Comment 2 Darin Adler 2013-10-05 12:06:33 PDT 
Created attachment 213466 [details]
Patch
Comment 3 EFL EWS Bot 2013-10-05 12:24:42 PDT 
Comment on attachment 213466 [details]
Patch

Attachment 213466 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3325055
Comment 4 EFL EWS Bot 2013-10-05 12:45:17 PDT 
Comment on attachment 213466 [details]
Patch

Attachment 213466 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/3340060
Comment 5 Build Bot 2013-10-05 12:47:16 PDT 
Comment on attachment 213466 [details]
Patch

Attachment 213466 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/3323060
Comment 6 Build Bot 2013-10-05 12:49:05 PDT 
Comment on attachment 213466 [details]
Patch

Attachment 213466 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3330064
Comment 7 Build Bot 2013-10-05 13:30:02 PDT 
Comment on attachment 213466 [details]
Patch

Attachment 213466 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/3395001
Comment 8 Darin Adler 2013-10-05 13:39:12 PDT 
Created attachment 213468 [details]
Patch
Comment 9 WebKit Commit Bot 2013-10-05 14:00:49 PDT 
Comment on attachment 213468 [details]
Patch

Rejecting attachment 213468 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 213468, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/ThirdParty/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/3426002
Comment 10 Build Bot 2013-10-05 14:19:46 PDT 
Comment on attachment 213468 [details]
Patch

Attachment 213468 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3424009
Comment 11 Darin Adler 2013-10-06 10:02:41 PDT 
Created attachment 213514 [details]
Patch
Comment 12 Darin Adler 2013-10-06 10:12:39 PDT 
Darn, the whole reason I updated a new patch was to get the Win EWS bot to test it, but for some reason the is no “win” bubble on this new patch.
Comment 13 Darin Adler 2013-10-06 10:13:59 PDT 
Committed r156989: <http://trac.webkit.org/changeset/156989>