WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
122390
Remove unneeded ScriptGCEvent class
https://bugs.webkit.org/show_bug.cgi?id=122390
Summary
Remove unneeded ScriptGCEvent class
Darin Adler
Reported
2013-10-05 11:53:41 PDT
Remove unneeded ScriptGCEvent class
Attachments
Patch
(35.74 KB, patch)
2013-10-05 12:06 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(35.68 KB, patch)
2013-10-05 13:39 PDT
,
Darin Adler
andersca
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
Patch
(34.65 KB, patch)
2013-10-06 10:02 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2013-10-05 12:02:31 PDT
***
Bug 122391
has been marked as a duplicate of this bug. ***
Darin Adler
Comment 2
2013-10-05 12:06:33 PDT
Created
attachment 213466
[details]
Patch
EFL EWS Bot
Comment 3
2013-10-05 12:24:42 PDT
Comment on
attachment 213466
[details]
Patch
Attachment 213466
[details]
did not pass efl-ews (efl): Output:
http://webkit-queues.appspot.com/results/3325055
EFL EWS Bot
Comment 4
2013-10-05 12:45:17 PDT
Comment on
attachment 213466
[details]
Patch
Attachment 213466
[details]
did not pass efl-wk2-ews (efl-wk2): Output:
http://webkit-queues.appspot.com/results/3340060
Build Bot
Comment 5
2013-10-05 12:47:16 PDT
Comment on
attachment 213466
[details]
Patch
Attachment 213466
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/3323060
Build Bot
Comment 6
2013-10-05 12:49:05 PDT
Comment on
attachment 213466
[details]
Patch
Attachment 213466
[details]
did not pass win-ews (win): Output:
http://webkit-queues.appspot.com/results/3330064
Build Bot
Comment 7
2013-10-05 13:30:02 PDT
Comment on
attachment 213466
[details]
Patch
Attachment 213466
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/3395001
Darin Adler
Comment 8
2013-10-05 13:39:12 PDT
Created
attachment 213468
[details]
Patch
WebKit Commit Bot
Comment 9
2013-10-05 14:00:49 PDT
Comment on
attachment 213468
[details]
Patch Rejecting
attachment 213468
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 213468, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/ThirdParty/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://webkit-queues.appspot.com/results/3426002
Build Bot
Comment 10
2013-10-05 14:19:46 PDT
Comment on
attachment 213468
[details]
Patch
Attachment 213468
[details]
did not pass win-ews (win): Output:
http://webkit-queues.appspot.com/results/3424009
Darin Adler
Comment 11
2013-10-06 10:02:41 PDT
Created
attachment 213514
[details]
Patch
Darin Adler
Comment 12
2013-10-06 10:12:39 PDT
Darn, the whole reason I updated a new patch was to get the Win EWS bot to test it, but for some reason the is no “win” bubble on this new patch.
Darin Adler
Comment 13
2013-10-06 10:13:59 PDT
Committed
r156989
: <
http://trac.webkit.org/changeset/156989
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug