Bug 122373 – Pass both Frame& and Document& to editing command functions.

• Component: HTML Editing
• Status: RESOLVED WONTFIX

[Andreas Kling]

Editing commands are only executed when there is both a Frame and a Document.
The code currently has to go through the Frame to the Document and all it gets is a pointer.
We should be nice and pass a Document& alongside the Frame& so we don't have to suffer the ambiguity.

[Andreas Kling]

Created attachment 213440 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 213440 [details]
Patch

rs=me.

[WebKit Commit Bot]

Comment on attachment 213440 [details]
Patch

Rejecting attachment 213440 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 213440, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
e: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/editing/EditorCommand.cpp
Hunk #9 FAILED at 396.
Hunk #12 FAILED at 463.
2 out of 28 hunks FAILED -- saving rejects to file Source/WebCore/editing/EditorCommand.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Ryosuke Niwa']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/3946205

[Andreas Kling]

Darin didn't like this, and I don't care anymore so let's just not do it.