Bug 122362

Summary: FramePolicyFunction should be an std::function
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, eflews.bot, gyuyoung.kim, japhet, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch darin: review+

Anders Carlsson
Reported 2013-10-04 17:13:18 PDT
FramePolicyFunction should be an std::function
Attachments
Patch (47.20 KB, patch)
2013-10-04 17:14 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (50.26 KB, patch)
2013-10-04 20:02 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (50.15 KB, patch)
2013-10-04 20:09 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (50.15 KB, patch)
2013-10-04 20:21 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (50.71 KB, patch)
2013-10-04 20:56 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-10-04 17:14:48 PDT
Created attachment 213421 [details] Patch
Darin Adler
Comment 2 2013-10-04 17:37:47 PDT
Comment on attachment 213421 [details] Patch Cute how you made the functions the last argument to match the “block is last argument” style we use for the corresponding Objective-C feature. Not sure if that’s the tradition for C++ but it does seem to make the code readable. I don’t think I’ll ever use a PTMF again!
EFL EWS Bot
Comment 3 2013-10-04 18:23:40 PDT
Comment on attachment 213421 [details] Patch Attachment 213421 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3322053
Build Bot
Comment 4 2013-10-04 18:57:21 PDT
Comment on attachment 213421 [details] Patch Attachment 213421 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/3314074
Anders Carlsson
Comment 5 2013-10-04 20:02:58 PDT
Created attachment 213434 [details] Patch
Anders Carlsson
Comment 6 2013-10-04 20:09:49 PDT
Created attachment 213436 [details] Patch
Anders Carlsson
Comment 7 2013-10-04 20:21:31 PDT
Created attachment 213437 [details] Patch
Build Bot
Comment 8 2013-10-04 20:55:06 PDT
Comment on attachment 213437 [details] Patch Attachment 213437 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/3326010
Anders Carlsson
Comment 9 2013-10-04 20:56:48 PDT
Created attachment 213438 [details] Patch
Anders Carlsson
Comment 10 2013-10-04 21:50:47 PDT
Committed r156946: <http://trac.webkit.org/changeset/156946>
Darin Adler
Comment 11 2013-10-05 06:47:46 PDT
This is causing link failures on the Mountain Lion bot, probably due to a standard library implementation problem. Various std::function-related symbols seem to be exported from WebKit2 even though we don’t want them to be.
Darin Adler
Comment 12 2013-10-05 06:48:26 PDT
Correction: The problem is on the Lion bot.
Note You need to log in before you can comment on or make changes to this bug.