Bug 122341

Summary:

Unify rubberband control

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, cmarcelo, commit-queue, jamesr, luiz, tonikitoo

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Sam Weinig 2013-10-04 12:39:01 PDT

Unify rubberband control

Comment 1 Sam Weinig 2013-10-04 15:38:19 PDT

Created attachment 213411 [details]
Patch

Comment 2 Sam Weinig 2013-10-04 16:24:28 PDT

Committed r156924: <http://trac.webkit.org/changeset/156924>

Comment 3 Tim Horton 2014-01-29 12:13:14 PST

Comment on attachment 213411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213411&action=review

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:64
> +    static bool linkedAgainstExecutableExpectingImplicitRubberBandControl = NSVersionOfLinkTimeLibrary("WebKit2") < 0x021A0200 /* 538.2.0 */;
> +    return linkedAgainstExecutableExpectingImplicitRubberBandControl;

NSVersionOfLinkTimeLibrary returns 0xffffffff for clients who don't link directly against WebKit2, like Safari. So, Safari is still getting the legacy implicit rubber-band control, while MiniBrowser is not, causing a great deal of confusion.