Bug 122340

Summary: [CSS Shapes] Image valued shape-outside shapes should update the layout after the image has been loaded
Product: WebKit Reporter: Hans Muller <giles_joplin>
Component: CSSAssignee: Hans Muller <giles_joplin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, esprehn+autocc, glenn, hyatt, kling, kondapallykalyan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 122197    
Bug Blocks: 116348    
Attachments:
Description Flags
Patch
simon.fraser: review+
Patch none

Hans Muller
Reported 2013-10-04 12:36:36 PDT
After a shape-outside image has been loaded and cached, everything that depends on the shape's float may need to be laid out again.
Attachments
Patch (6.15 KB, patch)
2013-10-09 14:09 PDT, Hans Muller 		simon.fraser: review+
DetailsFormatted DiffDiff
Patch (6.13 KB, patch)
2013-10-14 11:49 PDT, Hans Muller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hans Muller
Comment 1 2013-10-09 14:09:56 PDT
Created attachment 213812 [details] Patch Ensure that the a image valued shape-outside layout is updated after the image has been loaded.
Simon Fraser (smfr)
Comment 2 2013-10-14 10:54:22 PDT
Comment on attachment 213812 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213812&action=review > LayoutTests/ChangeLog:8 > + Verify that a image valued shape-outside layout is updated after the image has been loaded. an image-valued > LayoutTests/http/tests/css/css-image-valued-shape.html:10 > + -webkit-shape-outside: url("http://127.0.0.1:8000/resources/load-and-stall.php?name=square100.png&stallAt=0&stallFor=1"); Do you really need to include http://127.0.0.1:8000/ ?
Hans Muller
Comment 3 2013-10-14 11:49:40 PDT
Created attachment 214174 [details] Patch Made the suggested changes.
WebKit Commit Bot
Comment 4 2013-10-14 12:34:00 PDT
Comment on attachment 214174 [details] Patch Clearing flags on attachment: 214174 Committed r157414: <http://trac.webkit.org/changeset/157414>
WebKit Commit Bot
Comment 5 2013-10-14 12:34:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.