Bug 122327

Summary: [CSS Regions] Layout Tests for selecting text in 2 regions for other writing modes
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Tools / TestsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: achicu, commit-queue, jfernandez, mihnea, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 118668    
Attachments:
Description Flags
Patch none

Manuel Rego Casasnovas
Reported 2013-10-04 07:38:08 PDT
As commented in bug #121841 (https://bugs.webkit.org/show_bug.cgi?id=121841#c8) it would be good to have tests for other writing modes like in the case of other CSS Regions layout tests.
Attachments
Patch (16.84 KB, patch)
2013-10-04 07:43 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2013-10-04 07:43:37 PDT
Created attachment 213365 [details] Patch
Alexandru Chiculita
Comment 2 2013-10-04 13:13:51 PDT
Comment on attachment 213365 [details] Patch Looks good. Thanks!
WebKit Commit Bot
Comment 3 2013-10-04 13:35:52 PDT
Comment on attachment 213365 [details] Patch Rejecting attachment 213365 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 213365, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Tools/Scripts/update-webkit']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 121. Failed to run "['Tools/Scripts/update-webkit']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 121. Failed to run "['Tools/Scripts/update-webkit']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 121. Full output: http://webkit-queues.appspot.com/results/3292015
Manuel Rego Casasnovas
Comment 4 2013-10-04 14:58:31 PDT
Committed r156914: <http://trac.webkit.org/changeset/156914>
Manuel Rego Casasnovas
Comment 5 2013-10-04 14:58:57 PDT
Comment on attachment 213365 [details] Patch Clearing flags.
Note You need to log in before you can comment on or make changes to this bug.