Bug 122327 - [CSS Regions] Layout Tests for selecting text in 2 regions for other writing modes
Summary: [CSS Regions] Layout Tests for selecting text in 2 regions for other writing ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 118668
  Show dependency tree / graph
 
Reported: 2013-10-04 07:38 PDT by Manuel Rego Casasnovas
Modified: 2013-10-04 14:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (16.84 KB, patch)
2013-10-04 07:43 PDT, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2013-10-04 07:38:08 PDT 
As commented in bug #121841 (https://bugs.webkit.org/show_bug.cgi?id=121841#c8) it would be good to have tests for other writing modes like in the case of other CSS Regions layout tests.
Comment 1 Manuel Rego Casasnovas 2013-10-04 07:43:37 PDT 
Created attachment 213365 [details]
Patch
Comment 2 Alexandru Chiculita 2013-10-04 13:13:51 PDT 
Comment on attachment 213365 [details]
Patch

Looks good. Thanks!
Comment 3 WebKit Commit Bot 2013-10-04 13:35:52 PDT 
Comment on attachment 213365 [details]
Patch

Rejecting attachment 213365 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 213365, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
Tools/Scripts/update-webkit']" exit_code: 2

Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 121.

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 2

Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 121.

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 2
Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 121.

Full output: http://webkit-queues.appspot.com/results/3292015
Comment 4 Manuel Rego Casasnovas 2013-10-04 14:58:31 PDT 
Committed r156914: <http://trac.webkit.org/changeset/156914>
Comment 5 Manuel Rego Casasnovas 2013-10-04 14:58:57 PDT 
Comment on attachment 213365 [details]
Patch

Clearing flags.