Bug 122325

Summary: Remove WTF smart pointers 'const_pointer_cast'
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: Web Template FrameworkAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, darin, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Mikhail Pozdnyakov
Reported 2013-10-04 07:18:00 PDT
WTF smart pointers 'const_pointer_cast' functions are not used by anyone. Another reason is that const_pointer_cast functions are implemented wrongly (try to cast to a different pointer type).
Attachments
patch (2.97 KB, patch)
2013-10-04 07:22 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2013-10-04 07:22:08 PDT
Created attachment 213363 [details] patch
Darin Adler
Comment 2 2013-10-04 17:01:14 PDT
Comment on attachment 213363 [details] patch Seems OK. People aren’t using RefPtr<const X> anyway, and PassOwnPtr is on the way out.
WebKit Commit Bot
Comment 3 2013-10-04 17:24:49 PDT
Comment on attachment 213363 [details] patch Clearing flags on attachment: 213363 Committed r156931: <http://trac.webkit.org/changeset/156931>
WebKit Commit Bot
Comment 4 2013-10-04 17:24:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.