Bug 122299

Summary: [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
Product: WebKit Reporter: Tim Horton <thorton>
Component: Tools / TestsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bdakin, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
bdakin: review+
new patch, turn off threaded scrolling everywhere bdakin: review+

Tim Horton
Reported 2013-10-03 14:05:03 PDT
http://trac.webkit.org/changeset/156793 means that threaded scrolling is enabled by default for the WebKit2 API tests. This happened to break three tests. I’ve fixed the two relatively straightforward tests by using our synchronously-wait-for-the-scrolling-thread-to-tell-the-main-thread-the-new-position code that happens to be a part of the force repaint logic (unfortunately). I’ve fixed one other where that wasn’t working correctly by disabling threaded scrolling for that test.
Attachments
patch (5.92 KB, patch)
2013-10-03 14:16 PDT, Tim Horton 		bdakin: review+
DetailsFormatted DiffDiff
new patch, turn off threaded scrolling everywhere (5.98 KB, patch)
2013-10-04 11:24 PDT, Tim Horton 		bdakin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-10-03 14:16:15 PDT
Created attachment 213295 [details] patch
Tim Horton
Comment 2 2013-10-03 16:11:03 PDT
http://trac.webkit.org/changeset/156864
Tim Horton
Comment 3 2013-10-04 11:22:27 PDT
This is still happening flakily; I’ll just turn off threaded scrolling for all three tests.
Tim Horton
Comment 4 2013-10-04 11:24:35 PDT
Created attachment 213379 [details] new patch, turn off threaded scrolling everywhere
Tim Horton
Comment 5 2013-10-04 11:38:21 PDT
http://trac.webkit.org/changeset/156898
Note You need to log in before you can comment on or make changes to this bug.