Bug 122298 – Allow misspelling dots to overhang their constituent text by a single pixel

• Component: New Bugs
• Status: RESOLVED WONTFIX

[Myles C. Maxfield]

Allow misspelling dots to overhang their constituent text by a single pixel

[Myles C. Maxfield]

Created attachment 213289 [details]
Patch

[Myles C. Maxfield]

I don't want to rebaseline pixel tests until https://bugs.webkit.org/show_bug.cgi?id=122146 is taken care of

[Myles C. Maxfield]

<rdar://problem/15144058>

[Sam Weinig]

Why do we want to do this? Does it make something better?

[Myles C. Maxfield]

I'd say it does. Take a look at the screenshots. IMO the extra dot makes it look much better.

[Sam Weinig]

Comment on attachment 213289 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213289&action=review

How does this nudge work for other font sizes / fonts / glyphs in fonts.  This also needs tests.

> Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm:165
> +            width = ceil(width/patternWidth)*patternWidth;

Please put spaces around the  / and *.

[Sam Weinig]

(In reply to comment #5)
> I'd say it does. Take a look at the screenshots. IMO the extra dot makes it look much better.

There are no screenshots attached to the bugzilla.  You are probably referring to the radar, but please remember that not everyone has access to radar.

[Myles C. Maxfield]

Comment on attachment 213289 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213289&action=review

>> Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm:165
>> +            width = ceil(width/patternWidth)*patternWidth;
> 
> Please put spaces around the  / and *.

Done.