Bug 122275

Summary: [WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 122213    
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2013-10-03 08:57:26 PDT
[WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
Attachments
Patch (4.97 KB, patch)
2013-10-03 08:57 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.33 KB, patch)
2013-10-04 03:18 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-10-03 08:57:58 PDT
Created attachment 213258 [details] Patch
Darin Adler
Comment 2 2013-10-03 12:55:32 PDT
Comment on attachment 213258 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213258&action=review > Source/WebCore/fileapi/File.idl:30 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/fileapi/FileError.idl:35 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change.
Zan Dobersek
Comment 3 2013-10-04 03:18:34 PDT
Created attachment 213350 [details] Patch for landing Had to add the attribute to one more exception interface.
Zan Dobersek
Comment 4 2013-10-04 13:32:15 PDT
Comment on attachment 213350 [details] Patch for landing Clearing flags on attachment: 213350 Committed r156909: <http://trac.webkit.org/changeset/156909>
Zan Dobersek
Comment 5 2013-10-04 13:32:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.