Bug 122271

Summary:

[WebIDL] Annotate IDL interfaces under Source/WebCore/dom/ with the OperationsNotDeletable attribute

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, cmarcelo, commit-queue, esprehn+autocc, kangil.han, kondapallykalyan, WebkitBugTracker

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

122213

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Zan Dobersek

Reported 2013-10-03 08:49:47 PDT

[WebIDL] Annotate IDL interfaces under Source/WebCore/dom/ with the OperationsNotDeletable attribute

Attachments
Patch (38.99 KB, patch) 2013-10-03 08:52 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Patch for landing (26.86 KB, patch) 2013-10-04 03:13 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Zan Dobersek

Comment 1 2013-10-03 08:52:02 PDT

Created attachment 213254 [details] Patch

Darin Adler

Comment 2 2013-10-03 12:54:02 PDT

Comment on attachment 213254 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213254&action=review > Source/WebCore/dom/Attr.idl:24 > + OperationsNotDeletable No operations in this class, so it would be good not to make this change. > Source/WebCore/dom/BeforeLoadEvent.idl:29 > + OperationsNotDeletable No operations in this class, so it would be good not to make this change. > Source/WebCore/dom/BeforeUnloadEvent.idl:28 > + OperationsNotDeletable No operations in this class, so it would be good not to make this change. > Source/WebCore/dom/CDATASection.idl:21 > + OperationsNotDeletable No operations in this class, so it would be good not to make this change. > Source/WebCore/dom/ClientRect.idl:29 > + OperationsNotDeletable No operations in this class, so it would be good not to make this change. > Source/WebCore/dom/Comment.idl:21 > + OperationsNotDeletable No operations in this class, so it would be good not to make this change. > Source/WebCore/dom/CustomElementConstructor.idl:29 > + OperationsNotDeletable No operations in this class, so it would be good not to make this change. > Source/WebCore/dom/DOMError.idl:31 > + OperationsNotDeletable No operations in this class, so it would be good not to make this change. > Source/WebCore/dom/DocumentType.idl:22 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/dom/Entity.idl:21 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/dom/EntityReference.idl:21 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/dom/ErrorEvent.idl:34 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/dom/FocusEvent.idl:29 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/dom/MessageChannel.idl:35 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/dom/MutationRecord.idl:33 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/dom/Notation.idl:21 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/dom/PageTransitionEvent.idl:28 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/dom/PopStateEvent.idl:30 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/dom/ProcessingInstruction.idl:23 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/dom/ProgressEvent.idl:29 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/dom/SecurityPolicyViolationEvent.idl:28 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/dom/Touch.idl:29 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/dom/TransitionEvent.idl:29 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/dom/WebKitAnimationEvent.idl:28 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/dom/WebKitTransitionEvent.idl:28 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change.

Zan Dobersek

Comment 3 2013-10-04 03:13:17 PDT

Created attachment 213349 [details] Patch for landing Had to add the attribute to three exception interfaces declaring the toString operation and one more interface that implements an operation-declaring interface.

Zan Dobersek

Comment 4 2013-10-04 13:29:52 PDT

Comment on attachment 213349 [details] Patch for landing Clearing flags on attachment: 213349 Committed r156908: <http://trac.webkit.org/changeset/156908>

Zan Dobersek

Comment 5 2013-10-04 13:30:00 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.