Bug 122267

Summary: [EFL] [DEBUG] JavaScriptCore fails to build
Product: WebKit Reporter: Rob Płóciennik <r.plociennik>
Component: WebCore JavaScriptAssignee: Sergio Correia (qrwteyrutiyoup) <sergio>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, msaboff, r.plociennik, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Rob Płóciennik 2013-10-03 06:23:40 PDT 
Build fails due to an expression containing comparison between signed and unsigned integer.

Source/JavaScriptCore/llint/LLIntData.cpp: In static member function ‘static void JSC::LLInt::Data::performAssertions(JSC::VM&)’:
Source/JavaScriptCore/llint/LLIntData.cpp:128:5: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
Comment 1 Sergio Correia (qrwteyrutiyoup) 2013-10-03 07:24:00 PDT 
Created attachment 213244 [details]
Patch
Comment 2 Rob Płóciennik 2013-10-03 07:34:46 PDT 
How about changing it to:

ASSERT(MarkedBlock::blockMask == ~static_cast<decltype(MarkedBlock::blockMask)>(0xffff));
Comment 3 Sergio Correia (qrwteyrutiyoup) 2013-10-03 07:48:42 PDT 
(In reply to comment #2)
> How about changing it to:
> 
> ASSERT(MarkedBlock::blockMask == ~static_cast<decltype(MarkedBlock::blockMask)>(0xffff));

Nice suggestion. I am going to update the patch.
Comment 4 Sergio Correia (qrwteyrutiyoup) 2013-10-03 07:53:14 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > How about changing it to:
> > 
> > ASSERT(MarkedBlock::blockMask == ~static_cast<decltype(MarkedBlock::blockMask)>(0xffff));
> 
> Nice suggestion. I am going to update the patch.

Michael, I saw you have just r+'ed it; should I update the patch to apply Rob's suggestion?
Comment 5 Michael Saboff 2013-10-03 08:07:52 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > How about changing it to:
> > > 
> > > ASSERT(MarkedBlock::blockMask == ~static_cast<decltype(MarkedBlock::blockMask)>(0xffff));
> > 
> > Nice suggestion. I am going to update the patch.
> 
> Michael, I saw you have just r+'ed it; should I update the patch to apply Rob's suggestion?

Sure.  I just CQ-.  Maybe that stopped the bots.
Comment 6 Sergio Correia (qrwteyrutiyoup) 2013-10-03 09:35:33 PDT 
Created attachment 213271 [details]
Patch

Updated as per Rob's suggestion.
Comment 7 WebKit Commit Bot 2013-10-03 10:11:28 PDT 
Comment on attachment 213271 [details]
Patch

Clearing flags on attachment: 213271

Committed r156837: <http://trac.webkit.org/changeset/156837>
Comment 8 WebKit Commit Bot 2013-10-03 10:11:30 PDT 
All reviewed patches have been landed.  Closing bug.