Bug 122179

Summary: [Mac] Set NSApplication current event while sending events directly to views
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eflews.bot, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch darin: review+, eflews.bot: commit-queue-

Alexey Proskuryakov
Reported 2013-10-01 14:23:30 PDT
DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView, which doesn't update [NSApp currentEvent]. But there are many places in WebKit that use the current event. I think that some flakiness I'm seeing on bots and locally is because of this. Notably, tests that log mouse move events (like platform/mac/fast/events/objc-event-api.html) get fake events based on current event, and I'm guessing that they get incorrect modifiers from that.
Attachments
proposed patch (8.03 KB, patch)
2013-10-01 14:26 PDT, Alexey Proskuryakov 		darin: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-10-01 14:26:22 PDT
Created attachment 213120 [details] proposed patch
EFL EWS Bot
Comment 2 2013-10-01 14:45:08 PDT
Comment on attachment 213120 [details] proposed patch Attachment 213120 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/2908174
Alexey Proskuryakov
Comment 3 2013-10-01 15:44:48 PDT
Committed <http://trac.webkit.org/r154396>. EFL bot is wrong.
Note You need to log in before you can comment on or make changes to this bug.