Bug 122121

Summary: Remove timeout from shouldBecome* functions in js-test-pre
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
proposed patch rniwa: review+

Description Alexey Proskuryakov 2013-09-30 13:12:58 PDT
There is a family of functions in js-test-pre that check a condition every 5 milliseconds, and fail if it doesn't become true in 0.5 sec. They also take an argument for custom timeout, but there are no tests that pass it.

This is not how you write regression tests - anything can take longer than 0.5 seconds. We should just use global test timeout, not roll out ad hoc flaky solutions.

There is a lot of flakiness on tests such as editing/spelling/grammar-paste.html, and it seems entirely expected with a short timeout like this.
Comment 1 Alexey Proskuryakov 2013-09-30 13:15:14 PDT
Created attachment 213032 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2013-09-30 13:46:37 PDT
Committed <http://trac.webkit.org/r156678>.