Bug 122120

Summary: [GTK] Enable respect image orientation by default
Product: WebKit Reporter: Anton Obzhirov <obzhirov>
Component: WebKitGTKAssignee: Anton Obzhirov <obzhirov>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue, gustavo, gyuyoung.kim, mario, mrobinson, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch gustavo: review+

Anton Obzhirov
Reported 2013-09-30 12:51:32 PDT
[GTK] Add WK2 settings property for respect image orientation
Attachments
Patch (6.55 KB, patch)
2013-09-30 12:54 PDT, Anton Obzhirov 		no flags
DetailsFormatted DiffDiff
Patch (7.58 KB, patch)
2013-10-01 05:31 PDT, Anton Obzhirov 		no flags
DetailsFormatted DiffDiff
Patch (7.69 KB, patch)
2013-10-01 05:51 PDT, Anton Obzhirov 		no flags
DetailsFormatted DiffDiff
Patch (1.58 KB, patch)
2013-10-14 09:14 PDT, Anton Obzhirov 		gustavo: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Anton Obzhirov
Comment 1 2013-09-30 12:54:08 PDT
Created attachment 213029 [details] Patch
WebKit Commit Bot
Comment 2 2013-09-30 12:56:41 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2013-09-30 23:17:27 PDT
Comment on attachment 213029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213029&action=review I'm sorry I forgot to say in the other bug that you should also update the WebKitSettings unit tests. This is new API, so at least another GTK+ reviewer should approve it. > Source/WebKit2/ChangeLog:8 > + Add respect image orientation property in WK2 You should explain this a bit better, this is not a new property of WK2, but a new setting/property added to WebKitSettings API.
Anton Obzhirov
Comment 4 2013-10-01 05:31:00 PDT
Created attachment 213076 [details] Patch
Anton Obzhirov
Comment 5 2013-10-01 05:51:18 PDT
Created attachment 213077 [details] Patch
Gustavo Noronha (kov)
Comment 6 2013-10-01 06:06:38 PDT
Comment on attachment 213077 [details] Patch In principle I'm OK with the new API, but in the spirit of only adding features that are really needed to our new API I am wondering why would anyone want to disable this setting? Is there a use-case in sight, or is this a just-in-case thing?
Anton Obzhirov
Comment 7 2013-10-01 06:25:03 PDT
(In reply to comment #6) > (From update of attachment 213077 [details]) > In principle I'm OK with the new API, but in the spirit of only adding features that are really needed to our new API I am wondering why would anyone want to disable this setting? Is there a use-case in sight, or is this a just-in-case thing? It is useful option to disable/enable orientation - some sites can be designed not to take it into account for example. Also for the photo preview it can be useful sometime to preview photo in a way it was taken.
Anton Obzhirov
Comment 8 2013-10-01 09:31:40 PDT
Thanks Simon for the link - additional arguments about having setting to enable/disable image orientation can be found here: https://bugs.webkit.org/show_bug.cgi?id=19688.
Anton Obzhirov
Comment 9 2013-10-14 09:14:49 PDT
Created attachment 214155 [details] Patch
Anton Obzhirov
Comment 10 2013-10-14 09:18:11 PDT
After checking with Carlos and Gustavo: instead of adding the setting respect image orientation will be enabled by default.
Gustavo Noronha (kov)
Comment 11 2013-10-23 09:36:48 PDT
Comment on attachment 214155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214155&action=review > Source/WebKit2/ChangeLog:4 > + [GTK] Add WK2 settings property for respect image orientation > + https://bugs.webkit.org/show_bug.cgi?id=122120 LGTM, except this bug title is no longer correct, just fix the changelog, please? =)
Mario Sanchez Prada
Comment 12 2013-10-23 09:47:33 PDT
Committed r157861: <http://trac.webkit.org/changeset/157861>
Note You need to log in before you can comment on or make changes to this bug.