Bug 122117

Summary: getHostCallReturnValue needs to be implemented for Win64
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, mark.lam, msaboff
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch msaboff: review+

Alex Christensen
Reported 2013-09-30 12:39:04 PDT
r156490 broke the Win64 build. getHostCallReturnValue is now used but not implemented for Win64, which has no inline assembly capabilities. I based my assembly off the GCC assembly in JITOperations.cpp, and it works well enough to run sunspider. The Win64 test infrastructure still needs some improvements.
Attachments
patch (1.27 KB, patch)
2013-09-30 12:42 PDT, Alex Christensen 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-09-30 12:42:08 PDT
Created attachment 213026 [details] patch
Alex Christensen
Comment 2 2013-09-30 12:50:56 PDT
r156670
Note You need to log in before you can comment on or make changes to this bug.