Bug 122088

Summary: Remove FontTranscoder
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eflews.bot, gyuyoung.kim, kling, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
another kling: review+, eflews.bot: commit-queue-

Antti Koivisto
Reported 2013-09-30 00:54:41 PDT
This overly generic class just implements mapping of backslash to yen symbol for some legacy Japanese fonts.
Attachments
patch (38.87 KB, patch)
2013-09-30 01:07 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
another (31.08 KB, patch)
2013-09-30 01:14 PDT, Antti Koivisto 		kling: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-09-30 01:07:27 PDT
Created attachment 212959 [details] patch
Antti Koivisto
Comment 2 2013-09-30 01:14:55 PDT
Created attachment 212961 [details] another
EFL EWS Bot
Comment 3 2013-09-30 02:26:48 PDT
Comment on attachment 212961 [details] another Attachment 212961 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/2702155
Andreas Kling
Comment 4 2013-09-30 09:07:57 PDT
Comment on attachment 212961 [details] another r=me Also, wat.
Antti Koivisto
Comment 5 2013-09-30 09:22:00 PDT
https://trac.webkit.org/r156657
Alexey Proskuryakov
Comment 6 2013-09-30 09:48:44 PDT
> Also, wat. I can explain wat, and would have r-ed the patch. The idea was to use this class for other types of non-Unicode font transcoding. See bug 14637 and bug 22339. We just didn't do the work.
Sam Weinig
Comment 7 2013-09-30 09:52:04 PDT
(In reply to comment #6) > > Also, wat. > > I can explain wat, and would have r-ed the patch. > > The idea was to use this class for other types of non-Unicode font transcoding. See bug 14637 and bug 22339. We just didn't do the work. Given how long that work has not been completed for, it seems like this patch is justified. If we ever do that work, this (or something else) can be brought back.
Antti Koivisto
Comment 8 2013-09-30 10:05:52 PDT
Abstractions are costly in terms of code clarity and often performance. They should only be added for a concrete need.
Note You need to log in before you can comment on or make changes to this bug.