Summary: | Remove FontTranscoder | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
Component: | Text | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eflews.bot, gyuyoung.kim, kling, sam | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Antti Koivisto
2013-09-30 00:54:41 PDT
Created attachment 212959 [details]
patch
Created attachment 212961 [details]
another
Comment on attachment 212961 [details] another Attachment 212961 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/2702155 Comment on attachment 212961 [details]
another
r=me
Also, wat.
> Also, wat. I can explain wat, and would have r-ed the patch. The idea was to use this class for other types of non-Unicode font transcoding. See bug 14637 and bug 22339. We just didn't do the work. (In reply to comment #6) > > Also, wat. > > I can explain wat, and would have r-ed the patch. > > The idea was to use this class for other types of non-Unicode font transcoding. See bug 14637 and bug 22339. We just didn't do the work. Given how long that work has not been completed for, it seems like this patch is justified. If we ever do that work, this (or something else) can be brought back. Abstractions are costly in terms of code clarity and often performance. They should only be added for a concrete need. |